You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/08/28 19:16:28 UTC

[GitHub] anirudh2290 commented on a change in pull request #7638: [wip] CSRNDArray from/to scipy csr_matrix; fix rand_shape_nd

anirudh2290 commented on a change in pull request #7638: [wip] CSRNDArray from/to scipy csr_matrix; fix rand_shape_nd
URL: https://github.com/apache/incubator-mxnet/pull/7638#discussion_r135587839
 
 

 ##########
 File path: python/mxnet/test_utils.py
 ##########
 @@ -262,7 +262,7 @@ def rand_shape_3d(dim0=10, dim1=10, dim2=10):
 
 
 def rand_shape_nd(n, dim=10):
-    return rnd.randint(1, dim+1, size=n)
+    return tuple(rnd.randint(1, dim+1, size=n))
 
 Review comment:
   NITPICK: Would ndim or naxes make more sense here instead of n?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services