You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/16 14:55:35 UTC

[GitHub] [doris] morrySnow commented on a diff in pull request #10771: [Refactor](nereids)Refactor Literal to an inheritance hierarchy

morrySnow commented on code in PR #10771:
URL: https://github.com/apache/doris/pull/10771#discussion_r922688465


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Literal.java:
##########
@@ -85,12 +67,12 @@ public DataType getDataType() throws UnboundException {
 
     @Override
     public String toSql() {
-        return value.toString();
+        return String.valueOf(getValue());

Review Comment:
   NullLiteral and BooleanLiteral should return upper case in toSql and toString



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org