You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/07/16 02:18:18 UTC
[GitHub] codecov-io edited a comment on issue #2018: [Dubbo-2017]Fix redis
auth problem for RedisProtocol
codecov-io edited a comment on issue #2018: [Dubbo-2017]Fix redis auth problem for RedisProtocol
URL: https://github.com/apache/incubator-dubbo/pull/2018#issuecomment-402063688
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2018?src=pr&el=h1) Report
> Merging [#2018](https://codecov.io/gh/apache/incubator-dubbo/pull/2018?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6b5b4308c84acb979ff1cd0e46c327a84db1339c?src=pr&el=desc) will **increase** coverage by `0.8%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2018?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2018 +/- ##
===========================================
+ Coverage 52.14% 52.95% +0.8%
- Complexity 4902 5006 +104
===========================================
Files 562 570 +8
Lines 25216 25554 +338
Branches 4449 4493 +44
===========================================
+ Hits 13150 13532 +382
+ Misses 10060 9970 -90
- Partials 2006 2052 +46
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2018?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/rpc/protocol/redis/RedisProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL3JlZGlzL1JlZGlzUHJvdG9jb2wuamF2YQ==) | `59.75% <75%> (-0.25%)` | `6 <0> (ø)` | |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `58.33% <0%> (-14.09%)` | `5% <0%> (ø)` | |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `7% <0%> (-1%)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `42.25% <0%> (-11.27%)` | `15% <0%> (-1%)` | |
| [...le/src/main/java/com/alibaba/dubbo/rpc/Result.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9SZXN1bHQuamF2YQ==) | `22.22% <0%> (-11.12%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNsaWVudC5qYXZh) | `72.88% <0%> (-10.17%)` | `12% <0%> (-1%)` | |
| [...ache/dubbo/rpc/proxy/InvokerInvocationHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm94eS9JbnZva2VySW52b2NhdGlvbkhhbmRsZXIuamF2YQ==) | `30.76% <0%> (-4.02%)` | `3% <0%> (ø)` | |
| [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `51.87% <0%> (-1.93%)` | `54% <0%> (ø)` | |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=) | `77.2% <0%> (-1.48%)` | `29% <0%> (ø)` | |
| [.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvSW52b2tlci5qYXZh) | `68.33% <0%> (-1.16%)` | `11% <0%> (ø)` | |
| ... and [44 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2018/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2018?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2018?src=pr&el=footer). Last update [6b5b430...f3c3912](https://codecov.io/gh/apache/incubator-dubbo/pull/2018?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org