You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/11/08 18:59:47 UTC
[GitHub] [lucenenet] iamcarbon opened a new pull request, #754: Improve Code Quality
iamcarbon opened a new pull request, #754:
URL: https://github.com/apache/lucenenet/pull/754
- Enables C#10
- Use null propagation
- Removes various unused using statements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] iamcarbon closed pull request #754: Improve Code Quality
Posted by GitBox <gi...@apache.org>.
iamcarbon closed pull request #754: Improve Code Quality
URL: https://github.com/apache/lucenenet/pull/754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on a diff in pull request #754: Improve Code Quality
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on code in PR #754:
URL: https://github.com/apache/lucenenet/pull/754#discussion_r1017108884
##########
Directory.Build.props:
##########
@@ -26,7 +26,7 @@
</PropertyGroup>
<PropertyGroup>
- <LangVersion>9.0</LangVersion>
+ <LangVersion>10</LangVersion>
Review Comment:
This breaks support for VS2019, which we are still using. Please revert.
At least until someone upgrades [Git Tools 2019](https://marketplace.visualstudio.com/items?itemName=yysun.git-tools-2019) to support VS2022. See https://github.com/yysun/git-tools/issues/40.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] iamcarbon commented on pull request #754: Improve Code Quality
Posted by GitBox <gi...@apache.org>.
iamcarbon commented on PR #754:
URL: https://github.com/apache/lucenenet/pull/754#issuecomment-1307688666
Ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org