[GitHub] mistercrunch closed pull request #4943: [bugfix] handling UTF8 in Druid dimensions

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #4943: [bugfix] handling UTF8 in Druid dimensions
URL: https://github.com/apache/incubator-superset/pull/4943
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/connectors/druid/models.py b/superset/connectors/druid/models.py
index 4ff5e5fa09..c74fb9c3f5 100644
--- a/superset/connectors/druid/models.py
+++ b/superset/connectors/druid/models.py
@@ -1290,7 +1290,7 @@ def homogenize_types(df, groupby_cols):
         str instead of an object.
         """
         for col in groupby_cols:
-            df[col] = df[col].fillna('<NULL>').astype(str)
+            df[col] = df[col].fillna('<NULL>').astype('unicode')
         return df
 
     def query(self, query_obj):


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org