[GitHub] [kylin] hit-lacus commented on a change in pull request #1487: KYLIN-4826 kylin.source.hive.warehouse-dir can't found bug fix

[GitBox <gi...@apache.org>]

hit-lacus commented on a change in pull request #1487:
URL: https://github.com/apache/kylin/pull/1487#discussion_r531022464



##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -1053,6 +1055,15 @@ public int getJobOutputMaxSize() {
 
     public String getHiveDatabaseDir(String databaseName) {
         String dbDir = System.getProperty("kylin.source.hive.warehouse-dir");
+        if (StringUtils.isEmpty(dbDir)) {
+            logger.warn("get kylin.source.hive.warehouse-dir from system properties failed,now get it from overwrite configuration or kylin.properties");
+            dbDir = getOptional("kylin.source.hive.warehouse-dir", "");
+        }
+        if (StringUtils.isEmpty(dbDir)) {
+            logger.info("get kylin.source.hive.warehouse-dir success: {}", dbDir)
+        } else {
+            logger.warn("get kylin.source.hive.warehouse-dir failed.")

Review comment:
       Did you lose ";" ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org