You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/07/20 00:25:02 UTC

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #105: [MSHADE-396] Improve SourceContent Shading

kriegaex commented on pull request #105:
URL: https://github.com/apache/maven-shade-plugin/pull/105#issuecomment-882950852


   @Reamer
   > I have tested your version and found an error.
   
   Good catch! Because your previous change did not have an obvious test case, I did not understand why my code was wrong in this corner case. I have fixed it and added your test case, then squashed the change into the first commit.
   
   Barring a positive code review, I think this is ready to be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org