[GitHub] [brooklyn-ui] ahgittin opened a new pull request #129: UI for defining parameters

[GitBox <gi...@apache.org>]

ahgittin opened a new pull request #129: UI for defining parameters
URL: https://github.com/apache/brooklyn-ui/pull/129
 
 
   has a field-based mode and JSON mode
   
   builds on #118 , makes it mergeable
   
   ideally flaws in the PR can be tracked here but addressed in follow-on PRs unless critical.  i'm aware of the following wishlist items:
   
   1. if no params, it's not obvious how to add ("No params" should have option to "Add" one)
   2. are the icons in top-right of params section needed (filter etc)
   3. if same parameter entered twice you get angular errors
   4. parameters section should appear only on application (it's pointless elsewhere)
   5. parameters added should show up in the config section (maybe?)
   6. do all the fields work as expected when defining a parameter used subsequently (eg label, constraint)
   7. parameters are mostly pointless if you're deploying directly, it's mainly for saving and reuse (or some types of export)
   
   i think 1,4,6 need addressed imminently but i don't think they should block merging this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services