You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by gn...@apache.org on 2022/02/15 12:23:32 UTC

[maven] 01/02: Make all exceptions RuntimeException and introduce a common MavenException base type

This is an automated email from the ASF dual-hosted git repository.

gnodet pushed a commit to branch mvn4
in repository https://gitbox.apache.org/repos/asf/maven.git

commit d446d13e553b56c06a0bfc43ec24d59868c77a44
Author: Guillaume Nodet <gn...@gmail.com>
AuthorDate: Tue Feb 15 13:21:00 2022 +0100

    Make all exceptions RuntimeException and introduce a common MavenException base type
---
 .../api/services/ArtifactDeployerException.java    |  2 +-
 .../api/services/ArtifactFactoryException.java     |  2 +-
 .../api/services/ArtifactInstallerException.java   |  2 +-
 .../api/services/ArtifactResolverException.java    |  2 +-
 .../api/services/DependencyCollectorException.java |  2 +-
 .../api/services/DependencyFactoryException.java   |  2 +-
 .../api/services/DependencyResolverException.java  |  2 +-
 ...CollectorException.java => MavenException.java} | 35 ++++++++++++----------
 .../api/services/ProjectBuilderException.java      |  2 +-
 .../api/services/ProjectDeployerException.java     |  2 +-
 .../api/services/ProjectInstallerException.java    |  2 +-
 11 files changed, 30 insertions(+), 25 deletions(-)

diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactDeployerException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactDeployerException.java
index a5ac23a..ca9d9c4 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactDeployerException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactDeployerException.java
@@ -24,7 +24,7 @@ package org.apache.maven.api.services;
  * 
  */
 public class ArtifactDeployerException
-    extends Exception
+    extends MavenException
 {
 
     /**
diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactFactoryException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactFactoryException.java
index ee2f7a0..2a1cf37 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactFactoryException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactFactoryException.java
@@ -20,7 +20,7 @@ package org.apache.maven.api.services;
  */
 
 public class ArtifactFactoryException
-    extends RuntimeException
+    extends MavenException
 {
 
     public ArtifactFactoryException( String message )
diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactInstallerException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactInstallerException.java
index 77c3f20..18da90a 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactInstallerException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactInstallerException.java
@@ -23,7 +23,7 @@ package org.apache.maven.api.services;
  * 
  */
 public class ArtifactInstallerException
-    extends Exception
+    extends MavenException
 {
 
     /**
diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactResolverException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactResolverException.java
index d243fc9..d5e442b 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactResolverException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/ArtifactResolverException.java
@@ -23,7 +23,7 @@ package org.apache.maven.api.services;
  * 
  */
 public class ArtifactResolverException
-    extends Exception
+    extends MavenException
 {
 
     private static final long serialVersionUID = 7252294837746943917L;
diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyCollectorException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyCollectorException.java
index 733e2f9..e04b557 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyCollectorException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyCollectorException.java
@@ -24,7 +24,7 @@ package org.apache.maven.api.services;
  * dependency graph.
  */
 public class DependencyCollectorException
-    extends Exception
+    extends MavenException
 {
     /**
      *
diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyFactoryException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyFactoryException.java
index 5ca1d43..e0c5f2f 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyFactoryException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyFactoryException.java
@@ -20,7 +20,7 @@ package org.apache.maven.api.services;
  */
 
 public class DependencyFactoryException
-    extends RuntimeException
+    extends MavenException
 {
 
     public DependencyFactoryException( String message )
diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyResolverException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyResolverException.java
index 77ee118..74bc04e 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyResolverException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyResolverException.java
@@ -23,7 +23,7 @@ package org.apache.maven.api.services;
  * The Exception class in case a resolving does not work.
  */
 public class DependencyResolverException
-    extends Exception
+    extends MavenException
 {
     private static final long serialVersionUID = 5320065249974323888L;
 
diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyCollectorException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/MavenException.java
similarity index 63%
copy from maven-core-api/src/main/java/org/apache/maven/api/services/DependencyCollectorException.java
copy to maven-core-api/src/main/java/org/apache/maven/api/services/MavenException.java
index 733e2f9..7b83387 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/DependencyCollectorException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/MavenException.java
@@ -19,24 +19,29 @@ package org.apache.maven.api.services;
  * under the License.
  */
 
-/**
- * Thrown in case of bad artifact descriptors, version ranges or other issues encountered during calculation of the
- * dependency graph.
- */
-public class DependencyCollectorException
-    extends Exception
+public class MavenException extends RuntimeException
 {
-    /**
-     *
-     */
-    private static final long serialVersionUID = -3134726259840210686L;
+    public MavenException()
+    {
+    }
+
+    public MavenException( String message )
+    {
+        super( message );
+    }
 
-    /**
-     * @param message The message you would give for the exception.
-     * @param cause The cause which is related to the message.
-     */
-    public DependencyCollectorException( String message, Throwable cause )
+    public MavenException( String message, Throwable cause )
     {
         super( message, cause );
     }
+
+    public MavenException( Throwable cause )
+    {
+        super( cause );
+    }
+
+    public MavenException( String message, Throwable cause, boolean enableSuppression, boolean writableStackTrace )
+    {
+        super( message, cause, enableSuppression, writableStackTrace );
+    }
 }
diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectBuilderException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectBuilderException.java
index a71c5e7..0189385 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectBuilderException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectBuilderException.java
@@ -23,7 +23,7 @@ package org.apache.maven.api.services;
  * The Exception class in case a resolving does not work.
  */
 public class ProjectBuilderException
-    extends Exception
+    extends MavenException
 {
     /**
      * @param message The message to give.
diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectDeployerException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectDeployerException.java
index 0884364..fd8ceb3 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectDeployerException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectDeployerException.java
@@ -23,7 +23,7 @@ package org.apache.maven.api.services;
  * The Exception class in case a resolving does not work.
  */
 public class ProjectDeployerException
-    extends Exception
+    extends MavenException
 {
     /**
      * @param message The message to give.
diff --git a/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectInstallerException.java b/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectInstallerException.java
index 1aaf536..f1c160f 100644
--- a/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectInstallerException.java
+++ b/maven-core-api/src/main/java/org/apache/maven/api/services/ProjectInstallerException.java
@@ -23,7 +23,7 @@ package org.apache.maven.api.services;
  * The Exception class in case a resolving does not work.
  */
 public class ProjectInstallerException
-    extends Exception
+    extends MavenException
 {
     /**
      * @param message The message to give.