You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "AntonRoskvist (via GitHub)" <gi...@apache.org> on 2023/10/04 12:11:58 UTC
[PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
AntonRoskvist opened a new pull request, #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641
…loss
If a destination has a remote binding but not a local one, certain MessageLoadBalancingTypes can cause message loss, transparent to the producer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on code in PR #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641#discussion_r1347672026
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java:
##########
@@ -61,6 +61,19 @@ public final class BindingsImpl implements Bindings {
// This is public as we use on test assertions
public static final int MAX_GROUP_RETRY = 10;
+ private boolean hasLocal;
+
+ private void checkBinding(Long bindingID, Binding binding) {
+ if (binding instanceof LocalQueueBinding) {
+ hasLocal = true;
+ }
+ }
+
+ private void checkBindinsIdMap() {
Review Comment:
Seems like a spelling error maybe "checkBindingsIdMap"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
Posted by "AntonRoskvist (via GitHub)" <gi...@apache.org>.
AntonRoskvist commented on PR #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641#issuecomment-1749412950
Hello @clebertsuconic, thanks for your addition to the PR, looks great! I'm not really following this new process here though... is this merged or should I still rebase and maybe squash the changes in my local branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641#issuecomment-1749172018
@AntonRoskvist I used a feature from GitHub where I pushed a commit to your repo.
if you could rebase your repo with your local fork, I added a commit, which I will run tests on it now.
if you could review it please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641#issuecomment-1749405232
@AntonRoskvist thanks for this contribution....
Please check my addition through your branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641#issuecomment-1749806571
So if you do a git fetch on your fork you will see my push into your fork.
But I have merged this already in main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641#discussion_r1347679760
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java:
##########
@@ -61,6 +61,19 @@ public final class BindingsImpl implements Bindings {
// This is public as we use on test assertions
public static final int MAX_GROUP_RETRY = 10;
+ private boolean hasLocal;
+
+ private void checkBinding(Long bindingID, Binding binding) {
+ if (binding instanceof LocalQueueBinding) {
+ hasLocal = true;
+ }
+ }
+
+ private void checkBindinsIdMap() {
Review Comment:
@tabish121 thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic merged PR #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641#discussion_r1347604650
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##########
@@ -1269,7 +1269,7 @@ private AddressInfo checkAddress(RoutingContext context, SimpleString address) t
Bindings simpleRoute(SimpleString address, RoutingContext context, Message message, AddressInfo addressInfo) throws Exception {
Bindings bindings = addressManager.getBindingsForRoutingAddress(address);
- if (bindings == null && context.getServerSession() != null) {
+ if ((bindings == null || !bindings.contains(LocalQueueBinding.class)) && context.getServerSession() != null) {
Review Comment:
simpleRoute is a hot method. This would cause an iteration on bindings to verify if hasLocal or not.
I'm amending your commit to have the attribute cached.
The only place this method was called (which was recently introduced) was during a queue creation.. and there it wouldn't be as hot as this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641#discussion_r1347641290
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/Bindings.java:
##########
@@ -63,7 +63,5 @@ public interface Bindings extends UnproposalListener {
int size();
- default boolean contains(Class clazz) {
- return false;
- }
+ boolean hasLocalBinding();
Review Comment:
I know this will have compilation failures :(... I'm fixing and I will push another commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4450 - Auto-deleted clustered destinations can cause message … [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4641:
URL: https://github.com/apache/activemq-artemis/pull/4641#issuecomment-1749806191
It is merged.
GitHub has a thing that if you allow. Members of the project can change your branch. I did that right from your fork :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org