You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by kai-chi <gi...@git.apache.org> on 2018/04/12 14:36:52 UTC
[GitHub] flink pull request #5840: [FLINK-7850] [build system] Give each maven profil...
GitHub user kai-chi opened a pull request:
https://github.com/apache/flink/pull/5840
[FLINK-7850] [build system] Give each maven profile an activation property
## What is the purpose of the change
This PR gives every maven profile an activation property so they can be activated with `-Dabcde`. This makes them a lot easier to work with in scripts that want to control profile activation, since you can just append `-D` switches.
## Brief change log
Maven profiles that were missing activation property got one with the name equal to profile's name
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kai-chi/flink 7850
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5840.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5840
----
----
---
[GitHub] flink pull request #5840: [FLINK-7850] [build system] Give each maven profil...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5840
---
[GitHub] flink pull request #5840: [FLINK-7850] [build system] Give each maven profil...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5840#discussion_r190155490
--- Diff: flink-libraries/flink-ml/pom.xml ---
@@ -116,6 +119,9 @@
<id>default</id>
<activation>
<activeByDefault>true</activeByDefault>
+ <property>
+ <name>default</name>
--- End diff --
This profile is never activated from the command-line and doesn't require the property.
---
[GitHub] flink pull request #5840: [FLINK-7850] [build system] Give each maven profil...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5840#discussion_r190155472
--- Diff: flink-libraries/flink-ml/pom.xml ---
@@ -103,6 +103,9 @@
<profile>
<id>windows</id>
<activation>
+ <property>
+ <name>windows</name>
--- End diff --
This profile is never activated from the command-line and doesn't require the property.
---