You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/07 16:21:56 UTC
[GitHub] [pulsar] lhotari opened a new pull request #14154: [Metadata] Let entries expire in the metadata caches
lhotari opened a new pull request #14154:
URL: https://github.com/apache/pulsar/pull/14154
### Motivation
- There's essentially a memory leak in the Metadata caches since the entries never expire in the current solution.
- `refreshAfterWrite` will never expire entries. After the given time, the next request to the entry will
trigger a refresh in the background. The current entry will be used until the entry has been refreshed.
- documentation for Caffeine's refresh feature: https://github.com/ben-manes/caffeine/wiki/Refresh
### Modifications
- refresh after `CACHE_REFRESH_TIME_MILLIS / 2`
- expire after `CACHE_REFRESH_TIME_MILLIS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14154: [Metadata] Let entries expire in the metadata caches
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14154:
URL: https://github.com/apache/pulsar/pull/14154#issuecomment-1031657442
@lhotari:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14154: [Metadata] Let entries expire in the metadata caches
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14154:
URL: https://github.com/apache/pulsar/pull/14154#issuecomment-1031656652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14154: [Metadata] Let entries expire in the metadata caches
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14154:
URL: https://github.com/apache/pulsar/pull/14154#issuecomment-1032238417
> I think it's better not to increase metadata load, how about
>
> * refresh after `CACHE_REFRESH_TIME_MILLIS`
> * expire after `CACHE_REFRESH_TIME_MILLIS * 2`
@Jason918 thanks, I changed it in this way. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14154: [Metadata] Let entries expire in the metadata caches
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14154:
URL: https://github.com/apache/pulsar/pull/14154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org