You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by bt...@apache.org on 2020/09/08 03:43:10 UTC
[james-project] 16/19: [Refactoring] Add missing BasicFeature tags
to some basic tests we would like to run with distributed james
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 5534282755fd7a214fb2a7e908209f3b3243299b
Author: Rene Cordier <rc...@linagora.com>
AuthorDate: Mon Sep 7 16:11:08 2020 +0700
[Refactoring] Add missing BasicFeature tags to some basic tests we would like to run with distributed james
---
.../jmap/rfc8621/contract/BackReferenceContract.scala | 4 +++-
.../jmap/rfc8621/contract/MailboxSetMethodContract.scala | 14 +++++++++++++-
.../contract/VacationResponseSetMethodContract.scala | 5 ++++-
3 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/BackReferenceContract.scala b/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/BackReferenceContract.scala
index 449e091..27317e1 100644
--- a/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/BackReferenceContract.scala
+++ b/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/BackReferenceContract.scala
@@ -25,8 +25,9 @@ import org.apache.http.HttpStatus.SC_OK
import org.apache.james.GuiceJamesServer
import org.apache.james.jmap.http.UserCredential
import org.apache.james.jmap.rfc8621.contract.Fixture._
+import org.apache.james.jmap.rfc8621.contract.tags.CategoryTags
import org.apache.james.utils.DataProbeImpl
-import org.junit.jupiter.api.{BeforeEach, Test}
+import org.junit.jupiter.api.{BeforeEach, Tag, Test}
trait BackReferenceContract {
@BeforeEach
@@ -43,6 +44,7 @@ trait BackReferenceContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def backReferenceResolvingShouldWork(): Unit = {
val response = `given`
.header(ACCEPT.toString, ACCEPT_RFC8621_VERSION_HEADER)
diff --git a/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxSetMethodContract.scala b/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxSetMethodContract.scala
index 407a7d4..abe1b84 100644
--- a/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxSetMethodContract.scala
+++ b/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxSetMethodContract.scala
@@ -32,6 +32,7 @@ import org.apache.james.GuiceJamesServer
import org.apache.james.jmap.draft.MessageIdProbe
import org.apache.james.jmap.http.UserCredential
import org.apache.james.jmap.rfc8621.contract.Fixture.{ACCEPT_RFC8621_VERSION_HEADER, ANDRE, BOB, BOB_PASSWORD, CEDRIC, DAVID, DOMAIN, authScheme, baseRequestSpecBuilder}
+import org.apache.james.jmap.rfc8621.contract.tags.CategoryTags
import org.apache.james.mailbox.MessageManager.AppendCommand
import org.apache.james.mailbox.model.MailboxACL.{EntryKey, Right}
import org.apache.james.mailbox.model.{MailboxACL, MailboxId, MailboxPath}
@@ -41,7 +42,7 @@ import org.apache.james.utils.DataProbeImpl
import org.assertj.core.api.Assertions.assertThat
import org.assertj.core.api.{Assertions, SoftAssertions}
import org.hamcrest.Matchers.{equalTo, hasSize}
-import org.junit.jupiter.api.{BeforeEach, Disabled, Test}
+import org.junit.jupiter.api.{BeforeEach, Disabled, Tag, Test}
trait MailboxSetMethodContract {
@@ -870,6 +871,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def mailboxSetShouldSubscribeMailboxWhenRequired(server: GuiceJamesServer): Unit = {
val request =
"""
@@ -1066,6 +1068,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def mailboxSetCreationShouldHandleRights(server: GuiceJamesServer): Unit = {
val request =
s"""
@@ -1411,6 +1414,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def mailboxSetShouldReturnCreatedWhenOnlyName(server: GuiceJamesServer): Unit = {
val request =
"""
@@ -1899,6 +1903,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def deleteShouldSucceedWhenMailboxExists(server: GuiceJamesServer): Unit = {
val mailboxId: MailboxId = server.getProbe(classOf[MailboxProbeImpl]).createMailbox(MailboxPath.forUser(BOB, "mailbox"))
@@ -2720,6 +2725,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def updateShouldRenameMailboxes(server: GuiceJamesServer): Unit = {
val mailboxId: MailboxId = server.getProbe(classOf[MailboxProbeImpl]).createMailbox(MailboxPath.forUser(BOB, "mailbox1"))
@@ -2876,6 +2882,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def updateShouldRenameSubscriptions(server: GuiceJamesServer): Unit = {
val request =
s"""
@@ -3590,6 +3597,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def deleteShouldSucceedWhenOnDestroyRemoveEmails(server: GuiceJamesServer): Unit = {
val mailboxId: MailboxId = server.getProbe(classOf[MailboxProbeImpl]).createMailbox(MailboxPath.forUser(BOB, "mailbox"))
val message: Message = Message.Builder
@@ -3846,6 +3854,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def updateShouldSubscribeMailboxes(server: GuiceJamesServer): Unit = {
val mailboxId: MailboxId = server.getProbe(classOf[MailboxProbeImpl]).createMailbox(MailboxPath.forUser(BOB, "mailbox"))
@@ -4769,6 +4778,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def updateShouldAllowSettingRights(server: GuiceJamesServer): Unit = {
val mailboxId = server.getProbe(classOf[MailboxProbeImpl]).createMailbox(MailboxPath.forUser(BOB, "mailbox"))
val request =
@@ -4841,6 +4851,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def updateShouldAllowResettingRights(server: GuiceJamesServer): Unit = {
val path = MailboxPath.forUser(BOB, "mailbox")
val mailboxId = server.getProbe(classOf[MailboxProbeImpl]).createMailbox(path)
@@ -5517,6 +5528,7 @@ trait MailboxSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def updateShouldAllowParentIdChangeWhenTopLevelMailbox(server: GuiceJamesServer): Unit = {
val parentId: MailboxId = server.getProbe(classOf[MailboxProbeImpl])
.createMailbox(MailboxPath.forUser(BOB, "parent"))
diff --git a/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/VacationResponseSetMethodContract.scala b/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/VacationResponseSetMethodContract.scala
index 9897383..c2adc5f 100644
--- a/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/VacationResponseSetMethodContract.scala
+++ b/server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/VacationResponseSetMethodContract.scala
@@ -27,8 +27,9 @@ import org.apache.http.HttpStatus.SC_OK
import org.apache.james.GuiceJamesServer
import org.apache.james.jmap.http.UserCredential
import org.apache.james.jmap.rfc8621.contract.Fixture._
+import org.apache.james.jmap.rfc8621.contract.tags.CategoryTags
import org.apache.james.utils.DataProbeImpl
-import org.junit.jupiter.api.{BeforeEach, Test}
+import org.junit.jupiter.api.{BeforeEach, Tag, Test}
trait VacationResponseSetMethodContract {
@BeforeEach
@@ -44,6 +45,7 @@ trait VacationResponseSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def updateShouldSucceed(server: GuiceJamesServer): Unit = {
val request =
s"""
@@ -218,6 +220,7 @@ trait VacationResponseSetMethodContract {
}
@Test
+ @Tag(CategoryTags.BASIC_FEATURE)
def partialUpdateShouldSucceed(server: GuiceJamesServer): Unit = {
val request =
s"""
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org