You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/12 09:27:00 UTC

[GitHub] [spark] Yikun commented on a diff in pull request #36159: [SPARK-38857][PYTHON] series name should be preserved in series.mode()

Yikun commented on code in PR #36159:
URL: https://github.com/apache/spark/pull/36159#discussion_r848205312


##########
python/pyspark/pandas/series.py:
##########
@@ -4400,6 +4400,8 @@ def mode(self, dropna: bool = True) -> "Series":
         Series
             Modes of the Series.
 
+        .. note:: Since Spark 3.4.0, series name is preserved to follow pandas 1.4+ behavior.

Review Comment:
   Sure, should we also mention these behavior changes in `docs/source/migration_guide/pyspark_3.3_to_3.4.rst`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org