You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/08/06 21:44:40 UTC

[Bug 58220] New: XSSFFont getFontHeight javadoc says "in points" but should say "in EMUs"

https://bz.apache.org/bugzilla/show_bug.cgi?id=58220

            Bug ID: 58220
           Summary: XSSFFont getFontHeight javadoc says "in points" but
                    should say "in EMUs"
           Product: POI
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: XSSF
          Assignee: dev@poi.apache.org
          Reporter: petteyg359@gmail.com

The Javadoc should specify the right unit that the method actually returns.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58220] XSSFFont getFontHeight javadoc says "in points" but should say "in EMUs"

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58220

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Nick Burch <ap...@gagravarr.org> ---
I don't think they are EMUs though, are they?

>From a quick check, the return looks to be in 20th points, just as with HSSF,
and as described at
https://poi.apache.org/apidocs/org/apache/poi/ss/usermodel/Font.html#getFontHeight%28%29

I'd propose replacing the XSSFFont javadoc with the Font or HSSFFont one, would
that solve the issue for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58220] XSSFFont getFontHeight javadoc says "in points" but should say "in EMUs"

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58220

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEEDINFO                    |RESOLVED

--- Comment #3 from Nick Burch <ap...@gagravarr.org> ---
Fixed in r1695528, and site republished with the updates in, thanks for your
advice!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58220] XSSFFont getFontHeight javadoc says "in points" but should say "in EMUs"

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58220

--- Comment #2 from petteyg359@gmail.com ---
That's probably best. Looking at the source, getFontHeightInPoints has nothing
but "@see #getFontHeight" which is rather inadequate documentation. HSSFFont
documentation actually exists :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org