You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "Aitozi (via GitHub)" <gi...@apache.org> on 2024/03/19 08:04:11 UTC
[PR] [core] support to drop partition when delete tag [incubator-paimon]
Aitozi opened a new pull request, #3042:
URL: https://github.com/apache/incubator-paimon/pull/3042
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #3041
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support to drop partition when delete tag [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #3042:
URL: https://github.com/apache/incubator-paimon/pull/3042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support to drop partition when delete tag [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3042:
URL: https://github.com/apache/incubator-paimon/pull/3042#discussion_r1530074749
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/BatchWriteGeneratorTagOperator.java:
##########
@@ -114,15 +117,15 @@ private void createTag() {
try {
// If the tag already exists, delete the tag
if (tagManager.tagExists(tagName)) {
- tagManager.deleteTag(tagName, tagDeletion, snapshotManager);
+ tagManager.deleteTag(tagName, tagDeletion, snapshotManager, callbacks);
Review Comment:
Be careful here, you need to create new callbacks, the callbacks will be closed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support to drop partition when delete tag [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed pull request #3042: [core] support to drop partition when delete tag
URL: https://github.com/apache/incubator-paimon/pull/3042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support to drop partition when delete tag [incubator-paimon]
Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on code in PR #3042:
URL: https://github.com/apache/incubator-paimon/pull/3042#discussion_r1531440715
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/BatchWriteGeneratorTagOperator.java:
##########
@@ -114,15 +117,15 @@ private void createTag() {
try {
// If the tag already exists, delete the tag
if (tagManager.tagExists(tagName)) {
- tagManager.deleteTag(tagName, tagDeletion, snapshotManager);
+ tagManager.deleteTag(tagName, tagDeletion, snapshotManager, callbacks);
Review Comment:
You are right, but I see some other same usage eg: `TagAutoCreation#callbacks`? I think it's the same error, do i have to fix it in this PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support to drop partition when delete tag [incubator-paimon]
Posted by "Aitozi (via GitHub)" <gi...@apache.org>.
Aitozi commented on code in PR #3042:
URL: https://github.com/apache/incubator-paimon/pull/3042#discussion_r1531436662
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveMetastoreClient.java:
##########
@@ -91,6 +91,22 @@ public void addPartition(LinkedHashMap<String, String> partitionSpec) throws Exc
}
}
+ @Override
+ public void deletePartition(LinkedHashMap<String, String> partitionSpec) throws Exception {
+ List<String> partitionValues = new ArrayList<>(partitionSpec.values());
+ try {
+ client.getPartition(
Review Comment:
Not necessary, removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support to drop partition when delete tag [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3042:
URL: https://github.com/apache/incubator-paimon/pull/3042#discussion_r1530075376
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveMetastoreClient.java:
##########
@@ -91,6 +91,22 @@ public void addPartition(LinkedHashMap<String, String> partitionSpec) throws Exc
}
}
+ @Override
+ public void deletePartition(LinkedHashMap<String, String> partitionSpec) throws Exception {
+ List<String> partitionValues = new ArrayList<>(partitionSpec.values());
+ try {
+ client.getPartition(
Review Comment:
Why we need to get first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] support to drop partition when delete tag [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3042:
URL: https://github.com/apache/incubator-paimon/pull/3042#discussion_r1531535045
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/BatchWriteGeneratorTagOperator.java:
##########
@@ -114,15 +117,15 @@ private void createTag() {
try {
// If the tag already exists, delete the tag
if (tagManager.tagExists(tagName)) {
- tagManager.deleteTag(tagName, tagDeletion, snapshotManager);
+ tagManager.deleteTag(tagName, tagDeletion, snapshotManager, callbacks);
Review Comment:
Yes, you can fix them together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org