You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2023/01/16 09:20:33 UTC

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #480: [FLINK-27845] Support column type evolution for file data

JingsongLi commented on code in PR #480:
URL: https://github.com/apache/flink-table-store/pull/480#discussion_r1071001147


##########
flink-table-store-common/src/main/java/org/apache/flink/table/store/file/predicate/LeafPredicate.java:
##########
@@ -84,7 +99,10 @@ public List<Object> literals() {
 
     @Override
     public boolean test(Object[] values) {

Review Comment:
   Maybe we can provide an interface instead of an object array for the input, so we have the opportunity to create something similar to `CastedRow` to avoid affecting the `LeafPredicate` code.
   
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org