You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/25 14:18:36 UTC

[GitHub] [skywalking] wu-sheng opened a new issue, #10033: [Feature] Discard `id()` method in the BanyanDB Measure process

wu-sheng opened a new issue, #10033:
URL: https://github.com/apache/skywalking/issues/10033

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   All metrics from OAL/MAL/Manual have an `id` method to generate a unique ID for this metric for persistence. 
   So, in the current implementation, there is an extra tag(Measure.ID) created by BanyanDB storage implementation.
   But, in the BanyanDB kernel level, ID is just a simple tag, which relies on an index structure, but not a time-series concept.
   Meanwhile, the current ShardingKey would be set to ID when not set.
   
   Considering all the above, we would face the low efficiency `BanyanDBMetricsDAO#multiGet` which relies on ID.at
   
   ### Use case
   
   To improve the circumstance, we should 
   1. Hard require for ShardingKey. No default sharding key, and no ID tag.
   2. Add ShardingKey to all metadata and manual metrics implementations.
   3. Rename ShardingKey to **SeriesID**, which indicate this is not just for sharding, but also used as a ID with timestamp.
   
   `BanyanDBMetricsDAO#multiGet` should only use the current time bucket and IDs extracted from a new `BanyanDBConverter#MeasureToStorage` implementation(only read SeriesIDs) to build `multiGet` query. 
   
   In the BanyanDB implementation, the `ID` would never be used in the query.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #10033: [Feature] Discard `id()` method in the BanyanDB Measure process

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #10033: [Feature] Discard `id()` method in the BanyanDB Measure process
URL: https://github.com/apache/skywalking/issues/10033


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #10033: [Feature] Discard `id()` method in the BanyanDB Measure process

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10033:
URL: https://github.com/apache/skywalking/issues/10033#issuecomment-1327971409

   Fix <3> through https://github.com/apache/skywalking/pull/10037


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #10033: [Feature] Discard `id()` method in the BanyanDB Measure process

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10033:
URL: https://github.com/apache/skywalking/issues/10033#issuecomment-1327534064

   FYI @lujiajing1126 Please take a look at this proposal. This is from the discussion between @hanahmily and me, when we try to locate https://github.com/apache/skywalking/pull/10032


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org