You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by alopresto <gi...@git.apache.org> on 2017/03/08 01:01:06 UTC

[GitHub] nifi pull request #1573: NIFI-3483 Added import statement to resolve failing...

GitHub user alopresto opened a pull request:

    https://github.com/apache/nifi/pull/1573

    NIFI-3483 Added import statement to resolve failing tests.

    PR 1566 added `NumberFormat` to fix a locale-dependent test but missed the import statement. 
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alopresto/nifi NIFI-3483

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1573
    
----
commit 6556107064cde01a219ad2a25585dd212fb5d784
Author: Andy LoPresto <al...@apache.org>
Date:   2017-03-08T00:58:47Z

    NIFI-3483 Added import statement to resolve failing tests.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1573: NIFI-3483 Added import statement to resolve failing tests.

Posted by alopresto <gi...@git.apache.org>.

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1573
  
    Aldrin's having a long day. The merge was successful but did not include the magic incantation to close the PR. Closing manually. Thanks all for the quick response. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1573: NIFI-3483 Added import statement to resolve failing tests.

Posted by alopresto <gi...@git.apache.org>.

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1573
  
    Thanks for the quick verification. I need a committer but I think @apiri is on it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1573: NIFI-3483 Added import statement to resolve failing tests.

Posted by apiri <gi...@git.apache.org>.

Github user apiri commented on the issue:

    https://github.com/apache/nifi/pull/1573
  
    Yeah, sorry about this.  Serves me right for trying to eyeball the merge.  Will get this in.  Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1573: NIFI-3483 Added import statement to resolve failing...

Posted by alopresto <gi...@git.apache.org>.

Github user alopresto closed the pull request at:

    https://github.com/apache/nifi/pull/1573


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---