You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/08/10 13:48:23 UTC
[GitHub] [rocketmq] ShannonDing opened a new pull request #3244: Open master protect and call pr review in develop branch
ShannonDing opened a new pull request #3244:
URL: https://github.com/apache/rocketmq/pull/3244
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Open master protect and call pr review in develop branch
## Brief changelog
add new asf.yaml
## Verifying this change
master can not be pushed force
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky closed pull request #3244: Open master protect and call pr review in develop branch
Posted by GitBox <gi...@apache.org>.
duhenglucky closed pull request #3244:
URL: https://github.com/apache/rocketmq/pull/3244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zhaohai1299002788 commented on pull request #3244: Open master protect and call pr review in develop branch
Posted by GitBox <gi...@apache.org>.
zhaohai1299002788 commented on pull request #3244:
URL: https://github.com/apache/rocketmq/pull/3244#issuecomment-896427432
Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project rocketmq-all: Too many files with unapproved license: 1 See RAT report in: /home/travis/build/apache/rocketmq/target/rat.txt -> [Help 1]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3244: Open master protect and call pr review in develop branch
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3244:
URL: https://github.com/apache/rocketmq/pull/3244#issuecomment-896053577
[](https://coveralls.io/builds/42034322)
Coverage increased (+0.08%) to 54.175% when pulling **fe00d284dabad950d2547d1e3c584e69e0fe95c9 on ShannonDing:branch_protect** into **44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org