[GitHub] [knox] jtran-cloudera commented on a change in pull request #88: KNOX-1855 - Add Service Definition for Cloudera Manager API

[GitBox <gi...@apache.org>]

jtran-cloudera commented on a change in pull request #88: KNOX-1855 - Add Service Definition for Cloudera Manager API
URL: https://github.com/apache/knox/pull/88#discussion_r278764697
 
 

 ##########
 File path: gateway-service-definitions/src/main/resources/services/cm/1.0.0/service.xml
 ##########
 @@ -0,0 +1,33 @@
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+
+<!--
+   Knox service definition for Cloudera Manager
+
+   Currently, this service definition covers only the CM API and not the web UI.
+
+   This service definition MUST be in its own topology and accessed without the
+   gateway/topology path in the request URL.
+-->
+<service role="CM" name="cm" version="1.0.0">
 
 Review comment:
   Which part are you referring to? Is it the use of the "CM" abbreviation in the comment, or the "CM"/"cm" strings in the role/name? It seems like the convention is to use a single word, all-capitalized, for the role name. So should it be "CLOUDERAMANAGER" instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services