You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/06/14 16:41:12 UTC
[GitHub] [accumulo] milleruntime commented on issue #1211: De-dupe some code
milleruntime commented on issue #1211: De-dupe some code
URL: https://github.com/apache/accumulo/pull/1211#issuecomment-502181494
> Nice deduplication.
>
> ZooUtil is probably a better place for the static method than embedded in ClientContext (it's better to keep the ZK stuff isolated to one spot, rather than intermingled with the rest of our utilities/internal code; it'll be easier to abstract ZK later).
Good idea. I wasn't sure of where the best place was for these methods.
I wanted to talk to @keith-turner about using Ample for deduping ```ZooKeeperInstance.getRootTabletLocation()``` but wasn't sure how to use it with the old code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services