You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@olingo.apache.org by "Elliott, Anthony (LNG-RDU)" <an...@lexisnexis.com> on 2014/08/13 23:13:32 UTC
Pull Request
I had some other changes that I needed for my situation. I've opened a pull request[1] on Github for those, should I do anything else for that?
[1]: https://github.com/apache/olingo-odata4/pull/2
Re: Pull Request
Posted by "Bolz, Michael" <mi...@sap.com>.
Hi Anthony,
Thanks again for your feedback and your contribution.
The best way to do contributions (changes) is via the Olingo JIRA
(https://issues.apache.org/jira/browse/OLINGO).
Create an issue which describe the fix/enhancement/ and if (as in your
case) code was changed attach the according "git diff" to the issue (as an
example see https://issues.apache.org/jira/browse/OLINGO-388).
After a check by a committer the change is merged and committed into the
master.
For your pull request via git hub I will now check which is the best way to
get it into Olingo.
I think we (you or I) should create at least according JIRA issues with the
short description you have written in the pull request.
Afterwards I would check the single commits and merge them on the master.
Is this ok for you an could you create the JIRA issues?
Kind regards,
Michael
From: <Elliott>, "Anthony (LNG-RDU)" <an...@lexisnexis.com>
Reply-To: "user@olingo.apache.org" <us...@olingo.apache.org>
Date: Mittwoch, 13. August 2014 23:13
To: "user@olingo.apache.org" <us...@olingo.apache.org>
Subject: Pull Request
I had some other changes that I needed for my situation. I¹ve opened a pull
request[1] on Github for those, should I do anything else for that?
[1]: https://github.com/apache/olingo-odata4/pull/2