You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/14 15:06:54 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request #17746: fix(explore): ensure sample pane results by read through
zhaoyongjie opened a new pull request #17746:
URL: https://github.com/apache/superset/pull/17746
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
closes: https://github.com/apache/superset/issues/17706
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r769459326
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
The key problem to solve here is that when the schema of table changed, we don't have a chance to refresh the sample cache. (the Superset isn't chance to get changes from the database)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17746:
URL: https://github.com/apache/superset/pull/17746#issuecomment-993666635
# [Codecov](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17746](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c7d083) into [master](https://codecov.io/gh/apache/superset/commit/8fe2f5ffff49f8c913e7df529f23998965ba0193?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fe2f5f) will **increase** coverage by `0.58%`.
> The diff coverage is `14.28%`.
> :exclamation: Current head 6c7d083 differs from pull request most recent head 9299da2. Consider uploading reports for the commit 9299da2 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17746 +/- ##
==========================================
+ Coverage 66.99% 67.58% +0.58%
==========================================
Files 1609 1602 -7
Lines 64797 64149 -648
Branches 6855 6773 -82
==========================================
- Hits 43409 43353 -56
+ Misses 19532 18943 -589
+ Partials 1856 1853 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `82.14% <14.28%> (-0.04%)` | :arrow_down: |
| postgres | `82.19% <14.28%> (-0.04%)` | :arrow_down: |
| python | `82.24% <14.28%> (-0.08%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `76.92% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `77.57% <0.00%> (-0.24%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdml6LnB5) | `58.16% <50.00%> (+0.03%)` | :arrow_up: |
| [superset/datasets/commands/export.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-8.78%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `91.89% <0.00%> (-5.41%)` | :arrow_down: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `88.23% <0.00%> (-3.93%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.77% <0.00%> (-1.62%)` | :arrow_down: |
| [superset/extensions.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `92.68% <0.00%> (-1.22%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `73.58% <0.00%> (-0.95%)` | :arrow_down: |
| ... and [53 more](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8fe2f5f...9299da2](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r768815648
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
because the source table schema might be changed. the `sample table` design by `get sample from source table`(in the other words, it isn't for a specific query, instead, answer: what data is in the source table) so we should do through query every time. (Breakthrough cache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r768815648
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
because the source table schema might be changed. the sample table design by `get sample from source table` so we should do through query every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r769451846
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
I see, but refetching on every panel open feels very suboptimal. Can we use `state.explore.datasource` from Redux instead? I think it holds the currently selected dataset, regardless of the latest query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r772406898
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
Thanks for the reminder! I think we need to make a tradeoff. BTW, there is a setting item: `SAMPLES_ROW_LIMIT = 1000` in config.py that how many sample rows will return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r768810954
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
Why do we make it dependent on `panelOpen`? I don't think we should rerun fetching samples on opening and closing the panel.
Also, I think that it shouldn't depend on `queryFormData?.adhoc_filters`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r768815648
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
because the source table schema might be changed. the `sample table` design by `get sample from source table`(in the other words, it isn't for a specific query, instead, answer: what data/schema is in the source table) so we should do through query every time. (Breakthrough cache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r768815648
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
because the source table schema might be changed. the `sample table` design by `get sample from source table` so we should do through query every time. (Breakthrough cache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r768814306
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -345,7 +346,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: false,
}));
- getData(RESULT_TYPES.samples);
+ getData(RESULT_TYPES.samples, true);
Review comment:
Maybe we should use object syntax to make it more descriptive? Like `getData(RESULT_TYPES.samples, { force: true });`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r769459326
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
The key problem to solve here is that when the schema of table changed, we don't have a chance to refresh the sample cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17746:
URL: https://github.com/apache/superset/pull/17746#issuecomment-993666635
# [Codecov](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17746](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c7d083) into [master](https://codecov.io/gh/apache/superset/commit/07bbe8448b2a63a6b22cb4b9670fa37f984ee5c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07bbe84) will **decrease** coverage by `0.14%`.
> The diff coverage is `14.28%`.
> :exclamation: Current head 6c7d083 differs from pull request most recent head 914ed28. Consider uploading reports for the commit 914ed28 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17746 +/- ##
==========================================
- Coverage 67.72% 67.58% -0.15%
==========================================
Files 1602 1602
Lines 64146 64149 +3
Branches 6773 6773
==========================================
- Hits 43442 43353 -89
- Misses 18851 18943 +92
Partials 1853 1853
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `82.14% <14.28%> (-0.01%)` | :arrow_down: |
| postgres | `82.19% <14.28%> (-0.01%)` | :arrow_down: |
| python | `82.24% <14.28%> (-0.31%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `76.92% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `77.57% <0.00%> (-0.24%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdml6LnB5) | `58.16% <50.00%> (+0.03%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.27% <0.00%> (-16.99%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `91.89% <0.00%> (-5.41%)` | :arrow_down: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `88.23% <0.00%> (-3.93%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.77% <0.00%> (-1.62%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [07bbe84...914ed28](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r768815648
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
because the source table schema might be changed. the `sample table` design by `get sample from source table` so we should do through query every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17746:
URL: https://github.com/apache/superset/pull/17746#issuecomment-993666635
# [Codecov](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17746](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de40855) into [master](https://codecov.io/gh/apache/superset/commit/8fe2f5ffff49f8c913e7df529f23998965ba0193?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fe2f5f) will **decrease** coverage by `0.20%`.
> The diff coverage is `14.28%`.
> :exclamation: Current head de40855 differs from pull request most recent head 9299da2. Consider uploading reports for the commit 9299da2 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17746 +/- ##
==========================================
- Coverage 67.17% 66.97% -0.21%
==========================================
Files 1609 1609
Lines 64797 64800 +3
Branches 6855 6855
==========================================
- Hits 43530 43397 -133
- Misses 19411 19547 +136
Partials 1856 1856
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `82.17% <14.28%> (-0.01%)` | :arrow_down: |
| postgres | `82.22% <14.28%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `82.27% <14.28%> (-0.46%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `76.92% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `77.57% <0.00%> (-0.24%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdml6LnB5) | `58.16% <50.00%> (+0.03%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `70.27% <0.00%> (-16.99%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `83.50% <0.00%> (-6.89%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `91.89% <0.00%> (-5.41%)` | :arrow_down: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `88.23% <0.00%> (-3.93%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/17746/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8fe2f5f...9299da2](https://codecov.io/gh/apache/superset/pull/17746?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r772406898
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
Thanks for the reminder! I think we need to make a tradeoff. BTW, there is a setting item: `SAMPLES_ROW_LIMIT = 1000` in config.py that how many sample rows will return.
What do you think about this issue? @evans @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r768761598
##########
File path: superset/viz.py
##########
@@ -258,8 +258,7 @@ def get_samples(self) -> List[Dict[str, Any]]:
"to_dttm": None,
}
)
- df = self.get_df_payload(query_obj)["df"] # leverage caching logic
Review comment:
In order to catch exception, return query payload instead Dataframe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r769627403
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
I remember when I was implementing the data tables panel that minimizing the number of requests was a big deal for many people and I'm afraid that it will be considered a regression when we send a new request on each opening of the panel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r768761598
##########
File path: superset/viz.py
##########
@@ -258,8 +258,7 @@ def get_samples(self) -> List[Dict[str, Any]]:
"to_dttm": None,
}
)
- df = self.get_df_payload(query_obj)["df"] # leverage caching logic
Review comment:
In order to catch exception, return query object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17746: fix(explore): ensure sample pane results by read through
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17746:
URL: https://github.com/apache/superset/pull/17746#discussion_r772406898
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -298,7 +299,7 @@ export const DataTablesPane = ({
...prevState,
[RESULT_TYPES.samples]: true,
}));
- }, [queryFormData?.adhoc_filters, queryFormData?.datasource]);
+ }, [queryFormData?.adhoc_filters, queryFormData?.datasource, panelOpen]);
Review comment:
Thanks for the reminder! I think we need to make a tradeoff. BTW, there is a setting item: `SAMPLES_ROW_LIMIT = 1000` in config.py that how many sample rows will return.
What do you think about this issue? @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org