You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/10 14:46:53 UTC

[GitHub] [incubator-kvrocks] tanruixiang commented on a diff in pull request #1172: Add timeout when replica connect master

tanruixiang commented on code in PR #1172:
URL: https://github.com/apache/incubator-kvrocks/pull/1172#discussion_r1045094117


##########
src/cluster/replication.cc:
##########
@@ -236,18 +237,23 @@ void ReplicationThread::CallbacksStateMachine::Start() {
     handlers_.emplace_front(CallbacksStateMachine::WRITE, "auth write", authWriteCB);
   }
 
+  uint64_t last_connect_timestamp = 0, connect_timeout_ms = 3100;

Review Comment:
   If `connect_timeout_ms` is not dynamically updated, it would be better to use constants?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org