You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/03/31 08:24:55 UTC

[GitHub] [echarts] pissang opened a new pull request #14568: fix(option): optimize error log when components or series are missing

pissang opened a new pull request #14568:
URL: https://github.com/apache/echarts/pull/14568


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ### What does this PR do?
   
   This pull request enhances the error log when built-in components or series are missing.
   
   Also, this PR fixes some issues in unit tests.
   
   
   ### Fixed issues
   
   https://github.com/apache/echarts/issues/14325
   
   
   ## Details
   
   ### Before: What was the problem?
   
   There is no log when components are missing. It may cause other more obscure errors which make developers hard to find out what the problem is.
   
   ### After: How is it fixed in this PR?
   
   Add more detailed components or series missing log.
   
   ![image](https://user-images.githubusercontent.com/841551/113112703-10a6ec00-923c-11eb-83f5-0f510ccd26a4.png)
   
   ![image](https://user-images.githubusercontent.com/841551/113113177-9dea4080-923c-11eb-9cc8-14c7ab537256.png)
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14568: fix(option): optimize error log when components or series are missing

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14568:
URL: https://github.com/apache/echarts/pull/14568#issuecomment-810878950


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #14568: fix(option): optimize error log when components or series are missing

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14568:
URL: https://github.com/apache/echarts/pull/14568


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14568: fix(option): optimize error log when components or series are missing

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14568:
URL: https://github.com/apache/echarts/pull/14568#issuecomment-811595587


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org