You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "grishick (via GitHub)" <gi...@apache.org> on 2025/07/30 06:35:26 UTC

[PR] NIFI-14801 Adding registryClientUrl and sslContextServiceId to create-reg-client and update-reg-client toolkit commands [nifi]

grishick opened a new pull request, #10149:
URL: https://github.com/apache/nifi/pull/10149

   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-14801](https://issues.apache.org/jira/browse/NIFI-14801)
   Adding registryClientUrl and sslContextServiceId to create-reg-client and update-reg-client toolkit commands
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [x] Build completed using `mvn clean install -P contrib-check`
   - [x] JDK 21
   
   ### Licensing
   
   - [x] No new dependencies
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14801 Adding registryClientUrl and sslContextServiceId to create-reg-client and update-reg-client toolkit commands [nifi]

Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 commented on PR #10149:
URL: https://github.com/apache/nifi/pull/10149#issuecomment-3140256755

   I'll close the PR as I don't think this is the right approach given this is currently implementation specific. If you do want/need to have everything in the same command I recommend looking at adding support for the `input` argument where one can give a file with a JSON representation of the component to instantiate. This is similar to existing commands such as `nifi create-service` for example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14801 Adding registryClientUrl and sslContextServiceId to create-reg-client and update-reg-client toolkit commands [nifi]

Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 closed pull request #10149: NIFI-14801 Adding registryClientUrl and sslContextServiceId to create-reg-client and update-reg-client toolkit commands
URL: https://github.com/apache/nifi/pull/10149


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-14801 Adding registryClientUrl and sslContextServiceId to create-reg-client and update-reg-client toolkit commands [nifi]

Posted by "grishick (via GitHub)" <gi...@apache.org>.
grishick commented on PR #10149:
URL: https://github.com/apache/nifi/pull/10149#issuecomment-3136876966

   @pvillard31 I get your point. I made this change on 1.2x because there wasn't set-reg-client-property command available there. I also don't see it in the new docs either: https://nifi.apache.org/nifi-docs/toolkit-guide.html, although I see it in the code. I think my main problem with create-reg-client is still that it always leaves me with an incomplete registry client, and in order to get a working registry client, I have to make an additional operation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org