You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/12/05 07:25:00 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #5028: Revert "[Refactor] Refactor DeleteHandler and Cond module (#4925)"
morningman opened a new pull request #5028:
URL: https://github.com/apache/incubator-doris/pull/5028
This reverts commit 9c9992e0aa28ee85364eebf86a6675f1073e08fb.
## Proposed changes
The PR #4925 will cause BE crash by following case:
```
CREATE TABLE `tbl1` (
`k1` int(11) NULL COMMENT "",
`k2` int(11) NULL COMMENT ""
) ENGINE=OLAP
DUPLICATE KEY(`k1`, `k2`)
COMMENT "OLAP"
DISTRIBUTED BY HASH(`k1`) BUCKETS 1
PROPERTIES (
"replication_num" = "1",
"in_memory" = "false",
"storage_format" = "V2"
);
insert into tbl1 values(1,2);
delete from tbl1 where k1=1;
alter table tbl1 modify column k2 bigint key;
```
BE will crash when doing schema change with delete condition.
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 merged pull request #5028: Revert "[Refactor] Refactor DeleteHandler and Cond module (#4925)"
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged pull request #5028:
URL: https://github.com/apache/incubator-doris/pull/5028
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on pull request #5028: Revert "[Refactor] Refactor DeleteHandler and Cond module (#4925)"
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #5028:
URL: https://github.com/apache/incubator-doris/pull/5028#issuecomment-739246369
Sorry about that, I'll try to fix it this weekend. Anyway, you can revert it before I fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org