[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8590: update how to release doc

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8590: update how to release doc
URL: https://github.com/apache/incubator-druid/pull/8590#discussion_r328947105
 
 

 ##########
 File path: distribution/asf-release-process-guide.md
 ##########
 @@ -191,10 +191,10 @@ Next create an issue in the Druid github to contain the release notes and allow
 Once the release branch is good for an RC, you can build a new tag with:
 
 ```
-mvn -DreleaseVersion=0.15.1-incubating -DdevelopmentVersion=0.15.2-incubating-SNAPSHOT -Dtag=druid-0.15.1-incubating-rc2 -DpushChanges=false clean release:clean release:prepare
+mvn -DreleaseVersion=0.16.0-incubating -DdevelopmentVersion=0.16.1-incubating-SNAPSHOT -Dtag=druid-0.16.0-incubating-rc3 -DpushChanges=false clean release:clean release:prepare
 
 Review comment:
   Hmm, some of the items are instructional/example command output that aren't likely so useful to copy and paste, and those mostly have a `$` prefix just to like set the scene I guess. Others, like some maven commands with tons of arguments are pretty useful to copy and paste while doing a release, and those mostly don't have a `$` prefix.
   
   However, this isn't super consistent throughout the doc, so I think we should either remove them all, or, make sure all command line arguments have them. 
   
   I'm slightly in favor of removing for easier copy and paste, but on the other hand, that it is useful for copy and paste also means that more of this process still likely able to be further automated..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org