You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/06/28 02:34:53 UTC
[PR] [SPARK-57730][SQL][TESTS] Mark `Hive(PartitionFiltering|ClientUserName)Suite` as `SlowHiveTest` [spark]
dongjoon-hyun opened a new pull request, #56841:
URL: https://github.com/apache/spark/pull/56841
### What changes were proposed in this pull request?
This PR annotates two Hive client test suites with `SlowHiveTest`:
- `HivePartitionFilteringSuite`
- `HiveClientUserNameSuite`
Both are parameterized suites that run once per supported Hive metastore version (2.0, 2.1, 2.2, 2.3, 3.0, 3.1, 4.0, 4.1), executed via their nested-suite aggregators (`HivePartitionFilteringSuites` / `HiveClientUserNameSuites`).
### Why are the changes needed?
These two suites are the two slowest in the `hive - other tests` job. In a recent run of that job (total 53m17s), they accounted for the top two suite runtimes:
| Suite | Time | Tests |
|-------|------|-------|
| `HivePartitionFilteringSuites` | 182.9s | 360 |
| `HiveClientUserNameSuites` | 145.2s | 24 |
Tagging them with `@SlowHiveTest` excludes them from the `hive - other tests` job (which sets `EXCLUDED_TAGS=org.apache.spark.tags.SlowHiveTest`) and routes them to the dedicated slow-Hive job, balancing the test job runtimes. This is consistent with how other heavy Hive suites (e.g. `HiveUDFSuite`, `HiveSerDeReadWriteSuite`, `DynamicPartitionPruningHiveScanSuite`) are already tagged.
### Does this PR introduce _any_ user-facing change?
No. This is a test-only change.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57730][SQL][TESTS] Mark `HiveClientUserNameSuite` as `SlowHiveTest` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #56841: [SPARK-57730][SQL][TESTS] Mark `HiveClientUserNameSuite` as `SlowHiveTest`
URL: https://github.com/apache/spark/pull/56841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57730][SQL][TESTS] Mark `Hive(PartitionFiltering|ClientUserName)Suite` as `SlowHiveTest` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56841:
URL: https://github.com/apache/spark/pull/56841#issuecomment-4824733000
`HivePartitionFilteringSuite` seems to take more time due to the Hive metastore jars downloading phase. I'm going to remove that from the scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57730][SQL][TESTS] Mark `HiveClientUserNameSuite` as `SlowHiveTest` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56841:
URL: https://github.com/apache/spark/pull/56841#issuecomment-4824973966
Merged to master/4.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57730][SQL][TESTS] Mark `Hive(PartitionFiltering|ClientUserName)Suite` as `SlowHiveTest` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56841:
URL: https://github.com/apache/spark/pull/56841#issuecomment-4824670032
Thank you, @MaxGekk !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57730][SQL][TESTS] Mark `HiveClientUserNameSuite` as `SlowHiveTest` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56841:
URL: https://github.com/apache/spark/pull/56841#issuecomment-4824972182
Hive tests passed evenly.
<img width="338" height="110" alt="Screenshot 2026-06-27 at 22 22 22" src="https://github.com/user-attachments/assets/e81a0e48-ed51-4e91-8f4a-aad714b528a9" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org