[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #5941: Issue 5940

["Dandandan (via GitHub)" <gi...@apache.org>]

Dandandan commented on code in PR #5941:
URL: https://github.com/apache/arrow-datafusion/pull/5941#discussion_r1161804695


##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -543,7 +542,7 @@ async fn collect_left_input(
         )
     })? / 7)
         .next_power_of_two();
-    // 32 bytes per `(u64, SmallVec<[u64; 1]>)`
+    // 32 bytes per `(u64, Vec<[u64; 1]>)`

Review Comment:
   This probably is a trade-off, joins with unique keys will probably get slower.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org