[GitHub] [doris] jackwener commented on a diff in pull request #17355: [refactor](Nereids): refactor PushdownLimit

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #17355:
URL: https://github.com/apache/doris/pull/17355#discussion_r1126313946


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/PushdownLimit.java:
##########
@@ -40,24 +39,32 @@
  * <p>
  * Limit can't be push down if it has a valid offset info.
  */
-public class LimitPushDown implements RewriteRuleFactory {
+public class PushdownLimit implements RewriteRuleFactory {
 
     @Override
     public List<Rule> buildRules() {
         return ImmutableList.of(
                 // limit -> join
                 logicalLimit(logicalJoin(any(), any())).whenNot(Limit::hasValidOffset)

Review Comment:
   ```java
   f (newJoin == null || limit.child().children().equals(newJoin.children())) {
                                   return null;
                               }
   ```
   
   use it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org