You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Nigel Daley (JIRA)" <ji...@apache.org> on 2006/11/10 23:54:37 UTC

[jira] Created: (HADOOP-710) block size isn't honored

block size isn't honored
------------------------

                 Key: HADOOP-710
                 URL: http://issues.apache.org/jira/browse/HADOOP-710
             Project: Hadoop
          Issue Type: Bug
          Components: dfs
    Affects Versions: 0.8.0
            Reporter: Nigel Daley


When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-710) block size isn't honored

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-710?page=all ]

Milind Bhandarkar updated HADOOP-710:
-------------------------------------

           Status: Patch Available  (was: In Progress)
    Fix Version/s: 0.9.0

Patch available.

> block size isn't honored
> ------------------------
>
>                 Key: HADOOP-710
>                 URL: http://issues.apache.org/jira/browse/HADOOP-710
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>         Assigned To: Milind Bhandarkar
>             Fix For: 0.9.0
>
>         Attachments: small-block.patch
>
>
> When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-710) block size isn't honored

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-710?page=all ]

Milind Bhandarkar updated HADOOP-710:
-------------------------------------

    Attachment: small-block.patch

Updated patch attached.

> block size isn't honored
> ------------------------
>
>                 Key: HADOOP-710
>                 URL: http://issues.apache.org/jira/browse/HADOOP-710
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>         Assigned To: Milind Bhandarkar
>             Fix For: 0.9.0
>
>         Attachments: small-block.patch
>
>
> When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HADOOP-710) block size isn't honored

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-710?page=all ]

Milind Bhandarkar reassigned HADOOP-710:
----------------------------------------

    Assignee: Milind Bhandarkar

> block size isn't honored
> ------------------------
>
>                 Key: HADOOP-710
>                 URL: http://issues.apache.org/jira/browse/HADOOP-710
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>         Assigned To: Milind Bhandarkar
>
> When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HADOOP-710) block size isn't honored

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HADOOP-710?page=comments#action_12448889 ] 
            
Milind Bhandarkar commented on HADOOP-710:
------------------------------------------

This is a bug in DFSClient.DFSOutputStream.write(byte[], int, int). It calls endBlock only when the buffer becomes full.

> block size isn't honored
> ------------------------
>
>                 Key: HADOOP-710
>                 URL: http://issues.apache.org/jira/browse/HADOOP-710
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>         Assigned To: Milind Bhandarkar
>
> When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-710) block size isn't honored

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-710?page=all ]

Milind Bhandarkar updated HADOOP-710:
-------------------------------------

    Attachment: small-block.patch

Patch attached. This patch fixes the bug in DFSOutputStream. It also contains a unit test to reproduce the bug in the absence of this bug-fix.


> block size isn't honored
> ------------------------
>
>                 Key: HADOOP-710
>                 URL: http://issues.apache.org/jira/browse/HADOOP-710
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>         Assigned To: Milind Bhandarkar
>         Attachments: small-block.patch
>
>
> When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-710) block size isn't honored

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-710?page=all ]

Milind Bhandarkar updated HADOOP-710:
-------------------------------------

    Attachment:     (was: small-block.patch)

> block size isn't honored
> ------------------------
>
>                 Key: HADOOP-710
>                 URL: http://issues.apache.org/jira/browse/HADOOP-710
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>         Assigned To: Milind Bhandarkar
>             Fix For: 0.9.0
>
>         Attachments: small-block.patch
>
>
> When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Work started: (HADOOP-710) block size isn't honored

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-710?page=all ]

Work on HADOOP-710 started by Milind Bhandarkar.

> block size isn't honored
> ------------------------
>
>                 Key: HADOOP-710
>                 URL: http://issues.apache.org/jira/browse/HADOOP-710
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>         Assigned To: Milind Bhandarkar
>
> When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-710) block size isn't honored

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-710?page=all ]

Doug Cutting updated HADOOP-710:
--------------------------------

    Status: Open  (was: Patch Available)

You should parenthesize that subtraction.  (a - b) -c is not the same as a - (b - c), and we shouldn't require developers to remember which a - b -c is (i.e., I can't).

> block size isn't honored
> ------------------------
>
>                 Key: HADOOP-710
>                 URL: http://issues.apache.org/jira/browse/HADOOP-710
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>         Assigned To: Milind Bhandarkar
>             Fix For: 0.9.0
>
>         Attachments: small-block.patch
>
>
> When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-710) block size isn't honored

Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-710?page=all ]

Milind Bhandarkar updated HADOOP-710:
-------------------------------------

    Status: Patch Available  (was: Open)

Patch available.

> block size isn't honored
> ------------------------
>
>                 Key: HADOOP-710
>                 URL: http://issues.apache.org/jira/browse/HADOOP-710
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>         Assigned To: Milind Bhandarkar
>             Fix For: 0.9.0
>
>         Attachments: small-block.patch
>
>
> When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-710) block size isn't honored

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-710?page=all ]

Doug Cutting updated HADOOP-710:
--------------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

I just committed this.  Thanks, Milind!

> block size isn't honored
> ------------------------
>
>                 Key: HADOOP-710
>                 URL: http://issues.apache.org/jira/browse/HADOOP-710
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.8.0
>            Reporter: Nigel Daley
>         Assigned To: Milind Bhandarkar
>             Fix For: 0.9.0
>
>         Attachments: small-block.patch
>
>
> When writing a buffer to an FSOutputStream using write(buffer,offset,length), the block size isn't honored when the block size is less than the buffer size.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira