You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "ryn5 (via GitHub)" <gi...@apache.org> on 2023/12/05 02:07:13 UTC

[PR] Remove the deprecated `none()` step [tinkerpop]

ryn5 opened a new pull request, #2377:
URL: https://github.com/apache/tinkerpop/pull/2377

   Removes none(), which was deprecated in favor of discard() in 3.7.2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace `none()` with `discard()` [tinkerpop]

Posted by "ryn5 (via GitHub)" <gi...@apache.org>.
ryn5 commented on code in PR #2377:
URL: https://github.com/apache/tinkerpop/pull/2377#discussion_r1433130575


##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/__.java:
##########
@@ -806,6 +805,13 @@ public static <A> GraphTraversal<A, Set<?>> difference(final Object values) {
         return __.<A>start().difference(values);
     }
 
+    /**
+     * @see GraphTraversal#discard()
+     */
+    public static <A> GraphTraversal<A, A> discard() {

Review Comment:
   This was originally added to pass a test that looks for steps being implemented in GraphTraversal, but after looking into it again it seems it should just be ignored as none() was previously, so I'll be adding "discard" as an ignore case and removing this function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace `none()` with `discard()` [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy merged PR #2377:
URL: https://github.com/apache/tinkerpop/pull/2377


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace `none()` with `discard()` [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2377:
URL: https://github.com/apache/tinkerpop/pull/2377#issuecomment-1865187463

   LGTM. VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace `none()` with `discard()` [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2377:
URL: https://github.com/apache/tinkerpop/pull/2377#issuecomment-1865134464

   VOTE+1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove the deprecated `none()` step [tinkerpop]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2377:
URL: https://github.com/apache/tinkerpop/pull/2377#issuecomment-1844144126

   ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `3 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`95787a2`)](https://app.codecov.io/gh/apache/tinkerpop/commit/95787a2c30950daa5a596efeb657006b1de0b86f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 76.18% compared to head [(`2d2dbbf`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2377?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 71.09%.
   
   | [Files](https://app.codecov.io/gh/apache/tinkerpop/pull/2377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [gremlin-go/driver/anonymousTraversal.go](https://app.codecov.io/gh/apache/tinkerpop/pull/2377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1nby9kcml2ZXIvYW5vbnltb3VzVHJhdmVyc2FsLmdv) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [gremlin-go/driver/traversal.go](https://app.codecov.io/gh/apache/tinkerpop/pull/2377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1nby9kcml2ZXIvdHJhdmVyc2FsLmdv) | 0.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/tinkerpop/pull/2377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2377      +/-   ##
   ============================================
   - Coverage     76.18%   71.09%   -5.10%     
   ============================================
     Files          1083       25    -1058     
     Lines         64990     3944   -61046     
     Branches       7258        0    -7258     
   ============================================
   - Hits          49514     2804   -46710     
   + Misses        12776      949   -11827     
   + Partials       2700      191    -2509     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2377?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace `none()` with `discard()` [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on code in PR #2377:
URL: https://github.com/apache/tinkerpop/pull/2377#discussion_r1432084359


##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/__.java:
##########
@@ -806,6 +805,13 @@ public static <A> GraphTraversal<A, Set<?>> difference(final Object values) {
         return __.<A>start().difference(values);
     }
 
+    /**
+     * @see GraphTraversal#discard()
+     */
+    public static <A> GraphTraversal<A, A> discard() {

Review Comment:
   I notice that there is no corresponding `none()` method being replaced here, is this needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org