You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2016/12/02 05:01:50 UTC
[GitHub] zeppelin pull request #1715: [ZEPPELIN-1740] Focus next paragraph after para...
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/1715
[ZEPPELIN-1740] Focus next paragraph after paragraph deletion
### What is this PR for?
This PR is for moving focus next paragraph after paragraph deletion using Ctrl-Alt-D.
After paragraph is removed by keyboard shortcut Ctrl-Alt-D, focus is gone.
We have to move mouse and click the next paragraph to get focus.
### What type of PR is it?
[Improvement]
### Todos
* None
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1740
### How should this be tested?
Check the focus after pressing Ctrl-Alt-D in paragraph.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1740
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1715.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1715
----
commit 7b22529c31f98991d3a5f8dc9cc39083b40d6dd1
Author: soralee <so...@nflabs.com>
Date: 2016-12-02T02:09:57Z
moved to next paragraph automatically
commit f921a6a004171f5e6599c51744b5bfe408a1643d
Author: soralee <so...@nflabs.com>
Date: 2016-12-02T04:34:16Z
moved to next paragraph automatically
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1715: [ZEPPELIN-1740] Focus next paragraph after para...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1715
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1715
Merge to master if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1715
Thanks @soralee for the nice improvement.
Tested and LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1715
Good feature!
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1715: [ZEPPELIN-1740] Focus next paragraph after paragraph d...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1715
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---