[jira] [Resolved] (SOLR-5864) Remove previous SolrCore as parameter on reload

["Tomás Fernández Löbbe (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tomás Fernández Löbbe resolved SOLR-5864.
-----------------------------------------
       Resolution: Fixed
    Fix Version/s: Trunk
                   5.0
         Assignee: Tomás Fernández Löbbe

> Remove previous SolrCore as parameter on reload
> -----------------------------------------------
>
>                 Key: SOLR-5864
>                 URL: https://issues.apache.org/jira/browse/SOLR-5864
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Tomás Fernández Löbbe
>            Priority: Trivial
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-5864.patch, SOLR-5864.patch, SOLR-5864.patch, SOLR-5864.patch
>
>
> Currently the reload method is reload(SolrResourceLoader resourceLoader, SolrCore prev), but all the times it’s called with “prev” being the same as “this”:
> core.reload(resourceLoader, core). 
> Frankly, I don’t think it even makes sense to call it in other way (it would be just to create the first reader with a different core than the one its being reloaded?)
> I think we should just remove the SolrCore parameter and let the "reload" method always reload the core where it's being called. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org