[jira] [Work logged] (AMQNET-572) Failover crashes when AMQ Server enforces TLS 1.2

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQNET-572?focusedWorklogId=476316&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476316 ]

ASF GitHub Bot logged work on AMQNET-572:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Aug/20 02:29
            Start Date: 31/Aug/20 02:29
    Worklog Time Spent: 10m 
      Work Description: brudo commented on pull request #3:
URL: https://github.com/apache/activemq-nms-openwire/pull/3#issuecomment-683517991


   Has this already been addressed separately in mainline? If not, I think this is an important PR to resolve conflicts and merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 476316)
    Time Spent: 20m  (was: 10m)

> Failover crashes when AMQ Server enforces TLS 1.2
> -------------------------------------------------
>
>                 Key: AMQNET-572
>                 URL: https://issues.apache.org/jira/browse/AMQNET-572
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>            Reporter: Dan Taflin
>            Priority: Critical
>         Attachments: Archivos-1.zip, failoverSslContext.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> When using the FailoverTransport with underlying SslTransports, and specifying Tls12 as the SslProtocol, the initial connection to the ActiveMQ server succeeds in establishing a TLS v1.2 session. But upon failover, when it tries to reconnect, the Tls12 specification is lost and the NMS client reverts to the default, which appears to be TLS 1.0.
> The consequence is that it is impossible to enforce TLS 1.2 on the server, because although the initial connection would succeed, subsequent ones crash the client.
> Here's a sample failover transport URL:
> {{failover:(ssl://server1.example.com:61616?transport.sslProtocol=Tls12,ssl://server2.example.com:61616?transport.sslProtocol=Tls12)}}
> I've traced the issue to the FailoverTransport.DoConnect() method, which, when obtaining the ConnectList in order to obtain a url to connect to, obtains a url without a querystring. So in the above example, transport.sslProtocol=Tls12 is gone. The source of this truncated url is the ConnectionControl command marshalled from the server.
> The solution would seem to be to create an SslContext class to keep track of the sslProtocol, similar to how the java version works. I have built a working prototype for us to use locally and would be willing to make it available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)