[GitHub] [incubator-druid] b-slim commented on issue #7676: Add OakIncrementalIndex to Druid

[GitBox <gi...@apache.org>]

b-slim commented on issue #7676: Add OakIncrementalIndex to Druid
URL: https://github.com/apache/incubator-druid/pull/7676#issuecomment-493536012
 
 
   Just one point, not sure what lock-free means here but when i do grep on synchronized i see the following  and some of those locks are used as part of memory allocation which i guess it is part of the hot path. 
   
   ``` java 
   core/src/main/java/com/oath/oak/InternalOakMap.java:            synchronized (childToAdd = iterChildren.next()) {
   core/src/main/java/com/oath/oak/NativeAllocator/BlocksPool.java:            synchronized (BlocksPool.class) { // can be easily changed to lock-free
   core/src/main/java/com/oath/oak/NativeAllocator/BlocksPool.java:                synchronized (BlocksPool.class) { // can be easily changed to lock-free
   core/src/main/java/com/oath/oak/NativeAllocator/BlocksPool.java:            synchronized (BlocksPool.class) { // can be easily changed to lock-free
   core/src/main/java/com/oath/oak/NativeAllocator/OakNativeMemoryAllocator.java:                    synchronized (this) {
   core/src/main/java/com/oath/oak/NativeAllocator/OakNativeMemoryAllocator.java:            synchronized (this) {
   core/src/main/java/com/oath/oak/NativeAllocator/OakNativeMemoryAllocator.java:            synchronized (this) {
   
   ``` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org