You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/02/11 02:21:44 UTC

[GitHub] jixuan1989 commented on a change in pull request #34: fix sonar

jixuan1989 commented on a change in pull request #34: fix sonar 
URL: https://github.com/apache/incubator-iotdb/pull/34#discussion_r255370805
 
 

 ##########
 File path: tsfile/src/main/java/org/apache/iotdb/tsfile/encoding/encoder/PlainEncoder.java
 ##########
 @@ -59,22 +63,20 @@ public void encode(boolean value, ByteArrayOutputStream out) {
   @Override
   public void encode(short value, ByteArrayOutputStream out) {
     if (this.endianType == EndianType.LITTLE_ENDIAN) {
-      out.write((value >> 0) & 0xFF);
+      out.write(value & 0xFF);
 
 Review comment:
   @LeiRui  note this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services