[jira] [Commented] (NIFI-4826) ListAzureBlobStorage doesn't write azure.blobname properly

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343176#comment-16343176 ] 

ASF GitHub Bot commented on NIFI-4826:
--------------------------------------

GitHub user zenfenan opened a pull request:

    https://github.com/apache/nifi/pull/2440

    NIFI-4826 Fixed azure.blobname in ListAzureBlobStorage

    - azure.blobname now has the value returned by CloudBlob.getName().
    - Tested for blobs located in a multiple hierarchy directory structure by connecting ListAzureBlobStorage with FetchAzureBlobStorage with the latter processor's "Blob" property set to ${azure.blobname}
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zenfenan/nifi NIFI-4826

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2440
    
----
commit 194b0cf0f3414f05d41a85872347a69e7bab023e
Author: zenfenan <si...@...>
Date:   2018-01-29T09:52:32Z

    NIFI-4826 Fixed azure.blobname in ListAzureBlobStorage

----


> ListAzureBlobStorage doesn't write azure.blobname properly
> ----------------------------------------------------------
>
>                 Key: NIFI-4826
>                 URL: https://issues.apache.org/jira/browse/NIFI-4826
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.2.0, 1.3.0, 1.4.0, 1.5.0
>            Reporter: zenfenan
>            Priority: Minor
>
> ListAzureBlobStorage as of now takes the substring from the blob's primary URI i.e. primaryUri.lastIndexOf('/') + 1 and writes that as azure.blobname. For ex, if the blob is in the path "mystorageaccountname.blob.core.windows.net/container-name/path/to/the/blob". It will write azure.blobname as "blob". So if we have the blob located under a multiple hierarchy directory structure such as the above one, it will be troublesome in the downstream processors like FetchAzureBlobStorage which expects the full blob name to be given i.e. "path/to/the/blob". Giving just "blob" here will fail.
> A workaround that can be followed right now, is to use "ExecuteScript" and get the substring from primary URI i.e. everything after the "https://"+storageAccountName+"/"+containerName+"/". A better approach would be to make use of the CloudBlob.getName() API provided in Azure SDK. It should be a minor change since we are already using this SDK and the class in our processor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)