[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #5957: Fix integration test

[GitBox <gi...@apache.org>]

mattjackson220 commented on a change in pull request #5957:
URL: https://github.com/apache/trafficcontrol/pull/5957#discussion_r660740773



##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices_test.go
##########
@@ -205,3 +207,177 @@ func TestMakeExampleURLs(t *testing.T) {
 		t.Errorf("MakeExampleURLs expected %v actual %v", expected, actual)
 	}
 }
+
+func TestReadGetDeliveryServices(t *testing.T) {
+	mockDB, mock, err := sqlmock.New()
+	if err != nil {
+		t.Fatalf("an error '%s' was not expected when opening a stub database connection", err)

Review comment:
       should be `%v`

##########
File path: traffic_ops/testing/api/v4/deliveryservices_test.go
##########
@@ -43,15 +42,15 @@ func TestDeliveryServices(t *testing.T) {
 		header.Set(rfc.IfModifiedSince, ti)
 		header.Set(rfc.IfUnmodifiedSince, ti)
 		if includeSystemTests {
-			SSLDeliveryServiceCDNUpdateTest(t)
-			CreateTestDeliveryServicesURLSignatureKeys(t)
-			GetTestDeliveryServicesURLSignatureKeys(t)
-			DeleteTestDeliveryServicesURLSignatureKeys(t)
-			CreateTestDeliveryServicesURISigningKeys(t)
-			GetTestDeliveryServicesURISigningKeys(t)
-			DeleteTestDeliveryServicesURISigningKeys(t)
-			DeleteCDNOldSSLKeys(t)
-			DeliveryServiceSSLKeys(t)
+			t.Run("Update CDN for a Delivery Service with SSL keys", SSLDeliveryServiceCDNUpdateTest)

Review comment:
       should we make these changes to the lines below outside of the if statement too? just for consistency?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org