You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/03/20 01:12:54 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #40480: [SPARK-42508][BUILD][FOLLOW-UP] Exlcude org.apache.spark.ml.param.FloatParam$ for Scala 2.13
HyukjinKwon opened a new pull request, #40480:
URL: https://github.com/apache/spark/pull/40480
### What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/40097 that proposes to exclude org.apache.spark.ml.param.FloatParam$ for Scala 2.13:
```
[error] spark-mllib: Failed binary compatibility check against org.apache.spark:spark-mllib_2.13:3.3.0! Found 1 potential problems (filtered 646)
[error] * object org.apache.spark.ml.param.FloatParam does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.ml.param.FloatParam$")
[error] java.lang.RuntimeException: Failed binary compatibility check against org.apache.spark:spark-mllib_2.13:3.3.0! Found 1 potential problems (filtered 646)
[error] at scala.sys.package$.error(package.scala:30)
[error] at com.typesafe.tools.mima.plugin.SbtMima$.reportModuleErrors(SbtMima.scala:89)
[error] at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$2(MimaPlugin.scala:36)
[error] at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$2$adapted(MimaPlugin.scala:26)
[error] at scala.collection.Iterator.foreach(Iterator.scala:943)
```
See https://github.com/apache/spark/actions/runs/4430000174/jobs/7771194350.
### Why are the changes needed?
To make Scala 2.13 build pass
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Will monitor the build after this gets merged at https://github.com/apache/spark/actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40480: [SPARK-42508][BUILD][FOLLOW-UP] Exlcude org.apache.spark.ml.param.FloatParam$ for Scala 2.13
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40480:
URL: https://github.com/apache/spark/pull/40480#issuecomment-1475527135
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40480: [SPARK-42508][BUILD][FOLLOW-UP] Exlcude org.apache.spark.ml.param.FloatParam$ for Scala 2.13
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40480:
URL: https://github.com/apache/spark/pull/40480#issuecomment-1475472825
cc @zhengruifeng FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40480: [SPARK-42508][BUILD][FOLLOW-UP] Exlcude org.apache.spark.ml.param.FloatParam$ for Scala 2.13
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40480: [SPARK-42508][BUILD][FOLLOW-UP] Exlcude org.apache.spark.ml.param.FloatParam$ for Scala 2.13
URL: https://github.com/apache/spark/pull/40480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org