You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by Andy Seaborne <an...@apache.org> on 2015/05/17 11:24:17 UTC
Re: jena git commit: Fixes for JENA-946
On 16/05/15 21:59, claude@apache.org wrote:
> http://git-wip-us.apache.org/repos/asf/jena/blob/25b36522/jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/handlers/SelectHandler.java
> ----------------------------------------------------------------------
> diff --git a/jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/handlers/SelectHandler.java b/jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/handlers/SelectHandler.java
> index 7dba795..37726d8 100644
> --- a/jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/handlers/SelectHandler.java
> +++ b/jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/handlers/SelectHandler.java
> @@ -17,14 +17,19 @@
> + public void addVar(String expression, Var var) throws ParseException {
> + SPARQLParser11 parser = new SPARQLParser11(new ByteArrayInputStream(
> + expression.getBytes()));
The function "ExprUtils.parse" will hide the implementation details of
parsing expressions.
Minor notes:
You don't have to convert to bytes - the parsers work from Readers and
Stringreaders are the one case reader are OK.
String.getBytes() is nearly always wrong! It uses the platform
character set so on MSWindows it is not UTF-8. Use
StandardCharsets.UTF_8 with getBytes unless provable something else is
needed..
Andy