You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/25 12:41:41 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #2379: Replace hbase-testing-util with docker container #2295
JiriOndrusek opened a new pull request #2379:
URL: https://github.com/apache/camel-quarkus/pull/2379
fixes https://github.com/apache/camel-quarkus/issues/2295
- I have to use docker image with tag `latest`, because it is the only tag available.
- Hbase is using zookeeper. Hbase client gets location of master hbase from zookeeper, which means that location uses internal hostnames from the docker. Network mode `host` is the only way how to avoid manipulation with the hosts configuration at the test server.
- Ports can not be random as the result of previous item.
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.ht
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2379: Replace hbase-testing-util with docker container #2295
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2379:
URL: https://github.com/apache/camel-quarkus/pull/2379#issuecomment-806898214
JVM tests passed - that should be enough for this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #2379: Replace hbase-testing-util with docker container #2295
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2379:
URL: https://github.com/apache/camel-quarkus/pull/2379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org