[GitHub] [incubator-brpc] gydong commented on a change in pull request #1297: fix ErrorToString

[GitBox <gi...@apache.org>]

gydong commented on a change in pull request #1297:
URL: https://github.com/apache/incubator-brpc/pull/1297#discussion_r539008922



##########
File path: src/butil/files/file.cc
##########
@@ -117,7 +117,9 @@ std::string File::ErrorToString(Error error) {
     case FILE_ERROR_IO:
       return "FILE_ERROR_IO";
     case FILE_ERROR_MAX:
-      break;

Review comment:
       FILE_ERROR_MAX is not a specific error, it's just a upper limit for that enum.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org