You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/04/23 08:00:22 UTC

Review Request 20602: Added a base PID set in log ZooKeeper network.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20602/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Bugs: MESOS-1231
    https://issues.apache.org/jira/browse/MESOS-1231


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/log/log.cpp ca97144 
  src/log/network.hpp 788d9eb 

Diff: https://reviews.apache.org/r/20602/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 20602: Added a base PID set in log ZooKeeper network.

Posted by Jie Yu <yu...@gmail.com>.

> On April 23, 2014, 4:58 p.m., Benjamin Hindman wrote:
> > It would be great to follow up in a subsequent review and add some tests. I guess these were missing originally ...

Will do it today! I'll get this committed first.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20602/#review41152
-----------------------------------------------------------


On April 23, 2014, 6 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20602/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 6 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1231
>     https://issues.apache.org/jira/browse/MESOS-1231
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/log.cpp ca97144 
>   src/log/network.hpp 788d9eb 
> 
> Diff: https://reviews.apache.org/r/20602/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 20602: Added a base PID set in log ZooKeeper network.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20602/#review41152
-----------------------------------------------------------

Ship it!


It would be great to follow up in a subsequent review and add some tests. I guess these were missing originally ...


src/log/network.hpp
<https://reviews.apache.org/r/20602/#comment74563>

    I think we should default this to the empty set.


- Benjamin Hindman


On April 23, 2014, 6 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20602/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 6 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1231
>     https://issues.apache.org/jira/browse/MESOS-1231
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/log.cpp ca97144 
>   src/log/network.hpp 788d9eb 
> 
> Diff: https://reviews.apache.org/r/20602/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>