You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/08/29 18:16:41 UTC
[kudu-CR](branch-1.5.x) [iwyu] fix on
Hello Adar Dembo, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7873
to review the following change.
Change subject: [iwyu] fix on <ext/alloc_traits.h>
......................................................................
[iwyu] fix on <ext/alloc_traits.h>
Fixed the issue where IWYU suggested to include the internal GCC header
<ext/alloc_traits.h>: added additional mapping file which declares the
header as a private one, suggesting to include one of the public header
files of the standard C++ library files.
Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9
Reviewed-on: http://gerrit.cloudera.org:8080/7867
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 5f34a7d09e21670e0450266e8e7fa8a8d151aebc)
---
M build-support/iwyu/iwyu-filter.awk
M build-support/iwyu/iwyu.sh
A build-support/iwyu/mappings/libstdcpp.imp
M src/kudu/cfile/index_btree.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/schema.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_util.cc
M src/kudu/experiments/merge-test.cc
M src/kudu/gutil/strings/split.cc
M src/kudu/integration-tests/exactly_once_writes-itest.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/internal_mini_cluster.cc
M src/kudu/integration-tests/log_verifier.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/registration-test.cc
M src/kudu/master/master-test.cc
M src/kudu/security/token-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/rowset_tree.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tserver/scanners-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/make_shared.h
M src/kudu/util/mt-threadlocal-test.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/threadpool-test.cc
40 files changed, 44 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/7873/1
--
To view, visit http://gerrit.cloudera.org:8080/7873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.5.x) [iwyu] fix on
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [iwyu] fix on <ext/alloc_traits.h>
......................................................................
Patch Set 1: Code-Review+2
I'm fine with backporting this, will make it easier to backport other changes in the future to this branch.
--
To view, visit http://gerrit.cloudera.org:8080/7873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.5.x) [iwyu] fix on
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] fix on <ext/alloc_traits.h>
......................................................................
Patch Set 1:
> What's your motivation for this backport?
I expect some amount of updates to be pushed in 1.5.x in the nearest future. If really so, I'd like to avoid IWYU giving false positives on the issues we already fixed in the main trunk. Otherwise, it would be more overrides of the Jenkins jobs due to IWYU failures and more grudge accumulating in regard of the flaky IWYU configuration.
--
To view, visit http://gerrit.cloudera.org:8080/7873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.5.x) [iwyu] fix on
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [iwyu] fix on <ext/alloc_traits.h>
......................................................................
[iwyu] fix on <ext/alloc_traits.h>
Fixed the issue where IWYU suggested to include the internal GCC header
<ext/alloc_traits.h>: added additional mapping file which declares the
header as a private one, suggesting to include one of the public header
files of the standard C++ library files.
Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9
Reviewed-on: http://gerrit.cloudera.org:8080/7867
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 5f34a7d09e21670e0450266e8e7fa8a8d151aebc)
Reviewed-on: http://gerrit.cloudera.org:8080/7873
Reviewed-by: Dan Burkert <da...@apache.org>
---
M build-support/iwyu/iwyu-filter.awk
M build-support/iwyu/iwyu.sh
A build-support/iwyu/mappings/libstdcpp.imp
M src/kudu/cfile/index_btree.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/schema.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_util.cc
M src/kudu/experiments/merge-test.cc
M src/kudu/gutil/strings/split.cc
M src/kudu/integration-tests/exactly_once_writes-itest.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/internal_mini_cluster.cc
M src/kudu/integration-tests/log_verifier.cc
M src/kudu/integration-tests/master-stress-test.cc
M src/kudu/integration-tests/registration-test.cc
M src/kudu/master/master-test.cc
M src/kudu/security/token-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/rowset_tree.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tserver/scanners-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/make_shared.h
M src/kudu/util/mt-threadlocal-test.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/threadpool-test.cc
40 files changed, 44 insertions(+), 43 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.5.x) [iwyu] fix on
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [iwyu] fix on <ext/alloc_traits.h>
......................................................................
Patch Set 1:
> I'm fine with backporting this, will make it easier to backport
> other changes in the future to this branch.
Thanks!
Yes, the idea of easier (conflict-free) back-porting of the future updates from the main trunk is also a driver for back-porting this change. And also I want to avoid false positives from the IWYU Jenkins configuration (at least, let's get rid of IWYU flakes which we already fixed in the main trunk).
--
To view, visit http://gerrit.cloudera.org:8080/7873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.5.x) [iwyu] fix on
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [iwyu] fix on <ext/alloc_traits.h>
......................................................................
Patch Set 1: Code-Review+2
What's your motivation for this backport?
--
To view, visit http://gerrit.cloudera.org:8080/7873
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f4b517e9816294d70c57110182132adc6cd46d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No