You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/05/28 16:54:54 UTC

Review Request 34768: Changed Configurations During Upgrade Are Reverted During Finalize

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34768/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-11487
    https://issues.apache.org/jira/browse/AMBARI-11487


Repository: ambari


Description
-------

During a rolling upgrade from HDP 2.2 to HDP 2.3, several components such as MapR and Storm have their new HDP 2.3 configurations updated with {{ConfigureTask}} changes from the upgrade pack.

The database reflects the correct changes up until {{FinalizeUpgradeAction}} is invoked, after which the original HDP 2.3 values are re-inserted.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 0ac952c 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 1543ad7 
  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 98f7cfc 
  ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 710c046 

Diff: https://reviews.apache.org/r/34768/diff/


Testing
-------

mvn clean test


Thanks,

Jonathan Hurley


Re: Review Request 34768: Changed Configurations During Upgrade Are Reverted During Finalize

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34768/#review85552
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On May 28, 2015, 10:54 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34768/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 10:54 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11487
>     https://issues.apache.org/jira/browse/AMBARI-11487
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During a rolling upgrade from HDP 2.2 to HDP 2.3, several components such as MapR and Storm have their new HDP 2.3 configurations updated with {{ConfigureTask}} changes from the upgrade pack.
> 
> The database reflects the correct changes up until {{FinalizeUpgradeAction}} is invoked, after which the original HDP 2.3 values are re-inserted.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 0ac952c 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 1543ad7 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 98f7cfc 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 710c046 
> 
> Diff: https://reviews.apache.org/r/34768/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 34768: Changed Configurations During Upgrade Are Reverted During Finalize

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34768/#review85553
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On May 28, 2015, 2:54 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34768/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 2:54 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11487
>     https://issues.apache.org/jira/browse/AMBARI-11487
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During a rolling upgrade from HDP 2.2 to HDP 2.3, several components such as MapR and Storm have their new HDP 2.3 configurations updated with {{ConfigureTask}} changes from the upgrade pack.
> 
> The database reflects the correct changes up until {{FinalizeUpgradeAction}} is invoked, after which the original HDP 2.3 values are re-inserted.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 0ac952c 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 1543ad7 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 98f7cfc 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 710c046 
> 
> Diff: https://reviews.apache.org/r/34768/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>