You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Dave Brosius <db...@qis.net> on 2005/01/13 02:39:51 UTC

Common Struts usage problems

Hi folks,

    I was wondering if you folks had a list of common coding mistakes that people do with regards to using Struts that could be found by analysing byte code? I am a developer on Findbugs (findbugs.sourceforge.net) and would like to add detectors for such, if they exist. Thanks!


Re: Common Struts usage problems

Posted by James Mitchell <jm...@apache.org>.
If you analyze the wiki, you'll see a lot of this.

Might be nice if your tool supported enforcement of common 
patterns/practices (wrt DAO, layer separation, etc).

Just my 2 cents.

--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx

----- Original Message ----- 
From: "Dave Brosius" <db...@qis.net>
To: "Struts Developers List" <de...@struts.apache.org>
Sent: Wednesday, January 12, 2005 8:39 PM
Subject: Common Struts usage problems


Hi folks,

    I was wondering if you folks had a list of common coding mistakes that 
people do with regards to using Struts that could be found by analysing byte 
code? I am a developer on Findbugs (findbugs.sourceforge.net) and would like 
to add detectors for such, if they exist. Thanks!




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: Common Struts usage problems

Posted by Vic <vi...@friendvu.com>.
Dave Brosius wrote:

>Hi folks,
>
>    I was wondering if you folks had a list of common coding mistakes that people do with regards to using Struts that could be found by analysing byte code? I am a developer on Findbugs (findbugs.sourceforge.net) and would like to add detectors for such, if they exist. Thanks!
>
>
>  
>
A common one is to put properties in action subclasses at class level.  
(action is not thread safe like that, you have to pass in arguments to 
method).
You could enmerate declared actions by looking at the struts xml and 
check them out.

.V

-- 
RiA-SoA w/JDNC <http://www.SandraSF.com> forums
- help develop a community
My blog <http://www.sandrasf.com/adminBlog>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org