[jira] [Updated] (THRIFT-1942) Binary accelerated cpp extension does not use Thrift namespaces for Exceptions

["Tyler Hobbs (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tyler Hobbs updated THRIFT-1942:
--------------------------------

    Attachment: THRIFT-1942-v1.txt

Attached patch implements Jeremy's suggested fix.
                
> Binary accelerated cpp extension does not use Thrift namespaces for Exceptions
> ------------------------------------------------------------------------------
>
>                 Key: THRIFT-1942
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1942
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Compiler, PHP - Library
>    Affects Versions: 0.9
>            Reporter: Jeremy Rayner
>            Priority: Minor
>         Attachments: THRIFT-1942-v1.txt
>
>
> When an Exception is required to be thrown by the binary accelerated library, an Class Not Found error will occur:
> PHP Fatal error: Class 'TProtocolException' not found in XXXX
> Line 426 needs to change from
>   createObject("TProtocolException", ex, 2, zwhat, zerrorcode);
> to
>   createObject("\\Thrift\\Exception\\TProtocolException", ex, 2, zwhat, zerrorcode);
> and line 1104 needs to change from
> createObject("TApplicationException", ex);
> to
> createObject("\\Thrift\\Exception\\TApplicationException", ex);
> Basically, there is no accounting for the fact that the exception classes are now namespaced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira